remove null address from delegator count #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenyang007
approved these changes
Oct 24, 2024
| @@ -0,0 +1 @@ | |||
| DROP VIEW IF EXISTS num_active_delegator_per_pool; | |||
There was a problem hiding this comment.
nit, down should just be the previous query right? Or is this a new view?
|
sure! I’ll deploy tmr morning.
…On Wed, Oct 23, 2024 at 11:24 PM bowenyang007 ***@***.***> wrote:
***@***.**** approved this pull request.
looks good. @larry-aptos <https://github.com/larry-aptos> please help
deploy thanks!
—
Reply to this email directly, view it on GitHub
<#563 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2YC4BFOY2HQ3WIDULUKP2LZ5CHALAVCNFSM6AAAAABQP6TNB6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGOJRGQYTAMZYGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a delegator first receives a delegation in the UI it will show as having 3 active delegators.
ex. https://explorer.aptoslabs.com/txn/1828020008/changes?network=mainnet
The 3 table items with balance are
I've changed the tooltip to reflect that reward address will be included aptos-labs/explorer#836
This logic change removes the NULL address from being counted
Context on NULL address https://github.com/aptos-labs/aptos-core/blob/114d361d6cc7119f88eec11ae562c5ec6797275a/aptos-move/framework/aptos-framework/sources/delegation_pool.move#L1568